[Bug 785438] Review Request: php-horde-Horde-Url - Horde Url class

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=785438

--- Comment #1 from Remi Collet <fedora at famillecollet.com> 2012-01-30 09:53:15 EST ---
Same comment as others...

If you don't set Buildroot, you can also remove %clean

--- php-horde-Horde-Url.spec.old 2012-01-30 15:46:30.000000000 +0100
+++ php-horde-Horde-Url.spec 2012-01-30 15:51:21.000000000 +0100
@@ -12,13 +12,16 @@
 Source0:        http://pear.horde.org/get/%{pear_name}-%{version}.tgz

 BuildArch:      noarch
-BuildRequires:  php-pear >= 1:1.4.9-1.2
+BuildRequires:  php-pear(PEAR) >= 1.7.0
+BuildRequires:  php-channel(pear.horde.org)
+
 Requires(post): %{__pear}
 Requires(postun): %{__pear}
-Requires:       php-pear(pear.horde.org/Horde_Exception) <= 2.0.0,
php-pear(PEAR) >= 1.7.0
-Conflicts:      php-pear(pear.horde.org/Horde_Exception) = 2.0.0
-Provides:       php-pear(pear.horde.org/Horde_Url) = %{version}
-BuildRequires:  php-channel(pear.horde.org)
+Requires:       php-pear(pear.horde.org/Horde_Exception) >= 1.0.0
+Requires:       php-pear(pear.horde.org/Horde_Exception) <  2.0.0
+Requires: php-pear(PEAR) >= 1.7.0
+Requires: php-common >= 5.2.0
+Provides:       php-pear(pear.horde.org/%{pear_name}) = %{version}
 Requires:       php-channel(pear.horde.org)

 %description
@@ -51,10 +54,6 @@
 install -pm 644 %{name}.xml $RPM_BUILD_ROOT%{pear_xmldir}


-%clean
-rm -rf $RPM_BUILD_ROOT
-
-
 %post
 %{__pear} install --nodeps --soft --force --register-only \
     %{pear_xmldir}/%{name}.xml >/dev/null || :
@@ -67,13 +66,9 @@


 %files
-
 %{pear_xmldir}/%{name}.xml
-# Expand this as needed to avoid owning dirs owned by our dependencies
-# and to avoid unowned dirs
-%{pear_phpdir}/Horde/Url/Exception.php
+%{pear_phpdir}/Horde/Url
 %{pear_phpdir}/Horde/Url.php
-
 %{pear_testdir}/Horde_Url

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.