[Bug 783716] Review Request:gmail-notify-ext - Gmail checker Gnome Online Accounts based

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783716

--- Comment #4 from Stephen Gordon <sgordon at redhat.com> 2012-01-30 10:23:29 EST ---
The license string issue has been corrected :). I can also see you also added
an expanded description which is great, unfortunately though the lines in it
are > 80 characters long, please ensure you put line breaks in the description
field at or before 80 characters.

Otherwise the issues I raised in c#1 still stand:

- Use the %find_lang macro for the locale files:
  http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

- This looks like a noarch package but is not marked as such:
  http://fedoraproject.org/wiki/Common_Rpmlint_issues#no-binary

The following additional issues appear to have been introduced because upstream
have added a Greek translation but it is using the wrong locale (el instead of
gr):

gmail-notify-ext.x86_64: E: incorrect-locale-el
/usr/share/locale/gr/LC_MESSAGES
gmail-notify-ext.x86_64: E: invalid-lc-messages-dir
/usr/share/locale/gr/LC_MESSAGES/gmail_notify.mo

See http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-locale-el

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.