[Bug 480724] Review Request: ndjbdns - New djbdns, usable djbdns.

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 1 15:59:33 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480724

--- Comment #55 from Rahul Sundaram <metherid at gmail.com> 2012-03-01 10:59:27 EST ---
Is this necessary? --  export CFLAGS="$CFLAGS $RPM_OPT_FLAGS"  
The following is redundant:

rm -rf $RPM_BUILD_ROOT
%clean
rm -rf $RPM_BUILD_ROOT
%defattr(-,root,root,-)

Although not a blocker, I strongly urge you to consider renaming filepaths with
the project name.  /etc/ndjbdns instead of /etc/djbdns for instance to avoid
confusion with the original project.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list