[Bug 797370] Review Request: python-ssh - A Python SSH2 library

bugzilla at redhat.com bugzilla at redhat.com
Fri Mar 2 21:28:37 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=797370

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review?

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2012-03-02 16:28:36 EST ---
Review:
- name ok
- license ok
- URL ok
- source ok
  26800ef2c1ee3f185f48fd05258302f4  ssh-1.7.13.tar.gz
- noarch ok
- files ok
- rpmlint contains the incorrect-fsf-addresses from above nothing else, ok


NEEDSWORK:
- please add a %check section:
%check
./test.py --verbose

- There is a python3-crypto package in fc17 onwards. Could you please add a
python3 subpackage here too?
  Might be that ipython could use this too, and I'm trying to get all the
python3 dependencies fulfilled... (When you need a co-maintainer, let me know.)
  It seems to work after 2to3 and replacing tabs with 8 spaces.

- Please delete rm -rf ssh.egg-info/ in %prep just to be sure, that it's not
used laterly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list