[Bug 799810] Review Request: python-picloud - PiCloud client-side Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799810

--- Comment #1 from Volker Fröhlich <volker27 at gmx.at> 2012-03-05 02:08:00 EST ---
Just a few comments:

- Harmonize on either using $RPM_BUILD_ROOT or %{buildroot}
- Use the _mandir and _sysconfdir macro in the install section and preserve
timestamps for the files you install
- BR python-devel, see
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
- Package fails to build for me (Rawhide, i386) -- probably for the reason
above
- Since EL 5 has Python 2.4, you're package probably won't work. In that case,
you should remove the rm in the install section and the buildroot definition --
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.