[Bug 689112] Review Request: php-pear-File-CSV - Read and write of CSV files

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 5 17:11:10 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=689112

--- Comment #3 from Haïkel Guémar <karlthered at gmail.com> 2012-03-05 12:11:08 EST ---
It looks fine for me, except for the inconsistent use of $RPM_BUILDROOT and
%{buildroot} macros (i prefer macro-style over shell-style but you're free to
chose anyone). As soon as you fix this minor issue, i'll start the formal
review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list