[Bug 742605] Review Request: netcdf-cxx4 - netCDF-4 C++ library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=742605

Jon Ciesla <limburgher at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #6 from Jon Ciesla <limburgher at gmail.com> 2012-03-07 09:55:46 EST ---
Good:

- rpmlint checks return:

netcdf-cxx4.src: W: summary-not-capitalized C netCDF-4 C++ library
Summary doesn't begin with a capital letter.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Minor.

- package meets naming guidelines
- package meets packaging guidelines
- license ( NetCDF ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

What about shipping examples/ in %doc?

Otherwise, good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.