[Bug 742605] Review Request: netcdf-cxx4 - netCDF-4 C++ library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=742605

--- Comment #14 from Orion Poplawski <orion at cora.nwra.com> 2012-03-07 16:26:26 EST ---
(In reply to comment #13)
> New rpmlint output:
> 
> netcdf-cxx4.spec:137: W: configure-without-libdir-spec
> A configure script is run without specifying the libdir. configure options
> must be augmented with something like --libdir=%{_libdir} whenever the script
> supports it.

False positive, probably from   ln -s ../configure .

> netcdf-cxx4-devel.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/netcdf-cxx4-devel-4.2/examples/pres_temp_4D_wr.cpp
> This file has wrong end-of-line encoding, usually caused by creation or
> modification on a non-Unix system. It could prevent it from being displayed
> correctly in some circumstances.
> 
> netcdf-cxx4-devel.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/netcdf-cxx4-devel-4.2/examples/sfc_pres_temp_wr.cpp
> This file has wrong end-of-line encoding, usually caused by creation or
> modification on a non-Unix system. It could prevent it from being displayed
> correctly in some circumstances.

Fixed. 

> netcdf-cxx4-devel.x86_64: W: no-manual-page-for-binary ncxx4-config
> Each executable in standard binary directories should have a man page.

I'm not going to fix this, but I'll pass it along upstream.

> netcdf-cxx4-mpich2.x86_64: E: library-without-ldconfig-postin
> /usr/lib64/mpich2/lib/libnetcdf_c++4.so.1.0.2
> This package contains a library and provides no %post scriptlet containing a
> call to ldconfig.
> 
> netcdf-cxx4-mpich2.x86_64: E: library-without-ldconfig-postun
> /usr/lib64/mpich2/lib/libnetcdf_c++4.so.1.0.2
> This package contains a library and provides no %postun scriptlet containing a
> call to ldconfig.

These are not in the linker path.

> netcdf-cxx4-mpich2-devel.x86_64: W: only-non-binary-in-usr-lib
> There are only non binary files in /usr/lib so they should be in /usr/share.

This is how we are currently packaging mpi devel stuff.

> netcdf-cxx4-mpich2-devel.x86_64: W: no-documentation
> The package contains no documentation (README, doc, etc). You have to include
> documentation files.
> 
> netcdf-cxx4-mpich2-static.x86_64: W: no-documentation
> The package contains no documentation (README, doc, etc). You have to include
> documentation files.

I don't see any relevant documentation.

Spec URL: http://www.cora.nwra.com/~orion/fedora/netcdf-cxx4.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/netcdf-cxx4-4.2-4.fc16.src.rpm

* Wed Mar 7 2012 Orion Poplawski <orion at cora.nwra.com> - 4.2-4
- Fix line endings

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.