[Bug 720813] Review Request: python-strainer - Tools to allow developers to cleanup web serialization objects (HTML, JSON, XHTML)

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 8 19:41:19 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720813

--- Comment #5 from Volker Fröhlich <volker27 at gmx.at> 2012-03-08 14:41:17 EST ---
You don't need to put conditionals around the EPEL 5 specific elements, they
don't do any harm. They're just not necessary if you only packaged for EPEL 6
and Fedora only.

Please, whenever you post new specfiles and SRPMs, bump the release number and
leave a meaningful changelog entry in the spec file. It makes work easier for
the reviewer.

Removing the shebang from xhtmlify.py should fix the warning about it not being
executable as well.

The files section could be more explicit, but actually everything is fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list