[Bug 800930] Review Request: redeclipse - Multiplayer FPS game based on Cube2

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 8 21:25:08 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800930

--- Comment #12 from Brendan Jones <brendan.jones.it at gmail.com> 2012-03-08 16:25:08 EST ---
You need a %doc entry in the %files section of the main package. Read this: 
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing

In the license.txt upstream has been very clear about the source and the
content, your comments before your all license source is enough as long as you
make sure the sub-packages require the main package.

And seriously, lose all of the references to debian for your patches unless you
are referring to a specific bug report. The why is much more important than the
where. Better yet, refer to upstreams response to said bug report (I understand
the debian maintainer is upstream). Whatever is going to help maintain the
package longterm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list