[Bug 737293] Review Request: python-django - A high-level Python Web framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737293

--- Comment #8 from Bohuslav "Slavek" Kabrda <bkabrda at redhat.com> 2012-03-09 05:37:38 EST ---
(In reply to comment #7)
> (In reply to comment #5)
> > - I would still love to see some unit tests running in the check section. Is
> > there a way to do that?
> Me too. Sadly, a about 15 of those unit test currently fail. 
> 
> Updated to provide django lowercase (for django-doc, too)
> SPEC: http://www.matthias-runge.de/fedora/python-django.spec
> SRPM: http://www.matthias-runge.de/fedora/python-django-1.3.1-6.fc16.src.rpm
> 
> %check-update:
> tests in Django-1.4c1 don't succeed, either. E.g. the bundled simplejson has
> version 2.1.3; the test checks this. Our simplejson (in f16) is versioned 2.1.6
> 
> Tests are not required, so I'd tend to skip those as long as they can't enabled
> easily.

I believe that tests should be run. It is one of the few ways that packagers
have to find out if the software works correctly. The failures should be
reported upstream and fixed in cooperation with them. Only this way can we make
sure that the software will work on Fedora and that we will have good relations
with upstreams. (And I believe that cooperation with upstream, issue reporting
and fixing and suggesting enhancements is the packager's main job.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.