[Bug 798248] Review Request: rubygem-ruby-dbus - Ruby module for interaction with D-Bus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798248

Vít Ondruch <vondruch at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Vít Ondruch <vondruch at redhat.com> 2012-03-09 05:46:43 EST ---
(In reply to comment #3)
> (In reply to comment #2)
> > * Test suite execution
> >   - The test command you are using is somehow cryptic as well as the result is
> >     not comprehensive. Is this really the best approach? Wouldn't be better to
> >     fallback to rake in this particular case?
> 
> I found out an easier way:
> RUBYOPT="-I../lib" ./test_env testrb *_test.rb t[0-9]*.rb
> I think that this is quite straightforward and I would really not like to get
> to rake. Would this be ok for you?

Nice!

(In reply to comment #4)
> - So, I have created a patch that unbundles the libraries and upstream has
> accepted it [1], so this solves the bundling issue.

Sweet!

> - As for the provides/obsoletes of virtual provides, I have discussed with two
> proven packagers and they agreed, that the proper way is to obsolete and
> provide both the package name and its virtual provide (which was ruby(dbus) =
> %{version}). So the proper tags for this package should be (already in the
> updated spec):
> 
> Provides: ruby(dbus) = %{version}
> Provides: ruby-dbus = %{version}-%{release}
> Obsoletes: ruby(dbus) < 0.3.0
> Obsoletes: ruby-dbus < 0.3.0-5

There should be used "Obsoletes: ruby(dbus) <= 0.3.0", since you want to
obsolete ruby(dbus) includeing 0.3.0 version. The ruby-dbus obsolete should be
fine, since the version is higher that any version which was released.

* %{gem_instdir}/doc should be marked as %doc, also the examples might be
considered as a doc? I leave it up to you.

Otherwise the package looks good => APPROVED.

Please fix the two minor issues mentioned above prior committing and don't
forget to retire the ruby-dbus package properly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.