[Bug 480724] Review Request: ndjbdns - New djbdns, usable djbdns.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480724

--- Comment #57 from Rahul Sundaram <metherid at gmail.com> 2012-03-09 13:37:42 EST ---
Sorry for the delay.  Here is a more detailed review;

You should change the license header to specify the version info that matches
the license tag in the spec file

 * I've modified this file for good and am releasing this new version under
 * GNU General Public License.
 * Copyright (C) 2009 - 2011 Prasad J Pandit

This has to say GNU General Public License version 2 or later. It does say that
below so this is a bit redundant.  I won't insist on it but I recommend that. 

mkdir -p $RPM_BUILD_ROOT/%{_unitdir}
mv dnscache.service $RPM_BUILD_ROOT/%{_unitdir}/
mv tinydns.service $RPM_BUILD_ROOT/%{_unitdir}/

You should probably do the above in the makefile itself since you are upstream
and add a dependency list in the upstream source, say in the README file that
specifies that the source depends on systemd.  You should remove the reference
to service framework in the spec file description

If cdb is nominally considered to be a separate library, static linking
requires a exception from the Fedora packaging committee.  Otherwise, you need
to split that up and package it separately.  

ndjbdns.x86_64: W: no-manual-page-for-binary dnsipq
ndjbdns.x86_64: W: no-manual-page-for-binary tinydnsd
ndjbdns.x86_64: W: no-manual-page-for-binary dnstxt
ndjbdns.x86_64: W: no-manual-page-for-binary dnscached
ndjbdns.x86_64: W: no-manual-page-for-binary tcprules
ndjbdns.x86_64: W: no-manual-page-for-binary axfrdns-conf
ndjbdns.x86_64: W: no-manual-page-for-binary dnstracesort
ndjbdns.x86_64: W: no-manual-page-for-binary dnstrace
ndjbdns.x86_64: W: no-manual-page-for-binary randomip
ndjbdns.x86_64: W: no-manual-page-for-binary axfrdns
ndjbdns.x86_64: W: no-manual-page-for-binary dnsmx
ndjbdns.x86_64: W: no-manual-page-for-binary dnsname
ndjbdns.x86_64: W: no-manual-page-for-binary axfr-get
ndjbdns.x86_64: W: no-manual-page-for-binary dnsqr


Ideally all binaries need to include man pages.  The purpose of these binaries
are currently undocumented in the source.  Address these concerns and I will
approve you.  Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.