[Bug 577951] Review Request: mingw-wine-gecko - MinGW Gecko library required for Wine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577951

--- Comment #25 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> 2012-03-10 11:00:46 EST ---
Hey Andreas,

The mingw-w64 toolchain has just been added to Fedora 17 so this review should
now be able to continue.

Here are some minor improvements you could make:
- The first 3 lines of the .spec file (%global/%define) can be replaced by
%?mingw_package_header
- The BuildRoot tag and the line 'rm -rf %{buildroot}' can be removed now
- The -DMINGW_HAS_SECURE_API shouldn't be needed any more with mingw-w64. Could
you test if this package can be built without that define set?
- We (the Fedora MinGW SIG) decided to get rid of the %global mingw_pkg_name in
all mingw-* packages as it didn't have any added value. You also might want to
remove it
- The new MinGW packaging guidelines don't use brackets in RPM macro calls any
more, so you might want to change %{?mingw_debug_package} to
%?mingw_debug_package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.