[Bug 798998] Review Request: libcdr - a library for import of Corel Draw drawings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798998

Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschwendt at gmail.com

--- Comment #3 from Michael Schwendt <mschwendt at gmail.com> 2012-03-11 12:11:54 EDT ---
Thanks.  Meanwhile, I've had a look at things other than just the spec file:


* The licensing is not clear yet. Spec says:

> License: GPL+ or LGPLv2+ or MPLv1.1

That sounds like MPL tri-license, but the file contents disagree:

1) COPYING.GPL is the GPLv2 not GPL+

2) src/conv/raw/cdr2raw.cpp is LGPLv2+ only (!) and linking with libcdr

3) src/conv/svg/cdr2xhtml.cpp : MPLv1.1 tri-license header

4) src/lib/* :

   some files explicitly mention "MPL 1.1 / GPLv2+ / LGPLv2+",
   which is the tri-license

   CDRDocument.h : LGPLv2+ only (!)
   libcdr.h : LGPLv2+ only (!)

   All others contain the MPLv1.1 tri-license header with explicit
GPLv2+/LGPLv2+ option at the bottom.


The two files with LGPLv2+ header belong to the libcdr API,

  $ rpmls -p libcdr-devel-0.0.3-2.fc17.x86_64.rpm|grep \.h
  -rw-r--r--  /usr/include/libcdr-0.0/libcdr/CDRDocument.h
  -rw-r--r--  /usr/include/libcdr-0.0/libcdr/CDRStringVector.h
  -rw-r--r--  /usr/include/libcdr-0.0/libcdr/libcdr.h

and /usr/bin/cdr2raw is in the separate -tools package.

There is no statement that those files are dual-/multi-licensed in any way.
That makes the library LGPLv2+ licensed IMO. License clarification by the
developers would be helpful.


* I assume you are aware of these few items which are not needed in spec files
anymore:

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean


* There's an old packaging trick to ship subpackage documentation in the
subpackage's own versioned docdir. Currently:

$ rpmls -p libcdr-doc-0.0.3-2.fc17.noarch.rpm | grep ^d
drwxr-xr-x  /usr/share/doc/libcdr
drwxr-xr-x  /usr/share/doc/libcdr-doc-0.0.3
drwxr-xr-x  /usr/share/doc/libcdr/html

--- libcdr.spec.ORIG 2012-03-11 16:23:18.395893248 +0100
+++ libcdr.spec 2012-03-11 17:04:52.849667449 +0100
@@ -63,6 +63,7 @@
 rm -rf %{buildroot}
 make install DESTDIR=%{buildroot}
 rm -f %{buildroot}/%{_libdir}/*.la
+rm -rf _tmpdoc && mkdir _tmpdoc && mv %{buildroot}%{_docdir}/%{name}/html
_tmpdoc


 %clean
@@ -90,9 +91,7 @@

 %files doc
 %defattr(-,root,root,-)
-%doc COPYING.*
-%dir %{_docdir}/%{name}
-%{_docdir}/%{name}/html
+%doc _tmpdoc/html COPYING.*


 %files tools

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.