[Bug 790805] Review Request: lcg-util - Command line tools for wlcg data management

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=790805

--- Comment #3 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2012-03-12 15:48:06 EDT ---
Sorry for this late answer, I got really busy these last days.

Is there a particular reason for this Provides in the python subpackage?
    Provides:   %{name}-py%{python_version_nodot} = %{version}
Such Provides are not common in Fedora packages.

You can remove automake from the BuildRequires list, it's already required by
libtool and voms-devel.

You *MUST* use the %configure macro, instead of calling explicitely the
./configure script:
- the macro sets the appropriate CFLAGS/CXXFLAGS to build the program
- it already set most of the options you pass to configure

By the way, I wonder why you set the following options:

* --enable-debug → the debug flags are already in RPM_OPT_FLAGS
* --enable-wall → already in RPM_OPT_FLAGS too
* --with-pythonrelease=%{python_version} → the ./configure script is able to
find the defaut Python version/libs
* --with-version=%{version} / --with-release=%{release} → do you really need to
set explicitely the version of lcg-util at build time? This is all but robust.

It looks like lcg-util requires an old and specific version of swig (1.3.0),
obviously no more available in latest Fedora releases. Is it a real lack not to
have swig support for Fedora packages?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.