[Bug 797706] Review Request: ghc-aeson - Fast JSON parsing and encoding

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=797706

--- Comment #4 from Jens Petersen <petersen at redhat.com> 2012-03-14 00:11:51 EDT ---
Ok thanks for posting the fedora-review output.

BTW I just tried with 0.1.3 and it gives only:

Issues:
[!]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
[!]: MUST Development (unversioned) .so files in -devel subpackage, if
     present.
     Note: ghc-aeson-0.6.0.0-1.fc18.i686.rpm :
     /usr/lib/ghc-7.0.4/aeson-0.6.0.0/libHSaeson-0.6.0.0-ghc7.0.4.so
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages

As you can see ghc-aeson does include the license file so it
is false positive: maybe fedora-review only looks in the spec file?

The second one seems new to me and while valid generally I think
it can be waived here since ghc only created one single .so.
Indeed the SONAME of ghc shared libraries is the full filename.
In this context it might be more natural to write the filename
something like libHSaeson.so.0.6.0.0-ghc7.0.4.

Anyway this is obviously true for every ghc built shared library
already in Fedora so I suggest to waive this also since the
libraries are only used by ghc itself.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.