[Bug 771252] Review Request: cinnamon - Window management and application launching for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771252

--- Comment #36 from Christoph Wickert <cwickert at fedoraproject.org> 2012-03-14 08:21:50 EDT ---
(In reply to comment #35)
> We don't
> do code review as part of the review process clearly and there is no real
> history of even checking for functionality.  

I agree that a code review is not mandatory part of a package review,
nevertheless I consider it very useful. I recall a review that revealed serious
bugs and even a security issue in one of my packages. Me and the reviewer
worked on patches and I upstreamed them before the package was released in
Fedora. This is how successful collaboration between developers and package
maintainers should look like.

Besides that, checking for basic functionality *is* definitely part of the
review checklist: "The reviewer should test that the package functions as
described. A package should not segfault instead of running, for example."

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.