[Bug 801092] Review Request: sumwars - a hack and slash role playing game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=801092

--- Comment #9 from Martin Erik Werner <martinerikwerner at gmail.com> 2012-03-14 09:59:43 EDT ---
(In reply to comment #8)
> I tried to address all issues, hopefully I haven't missed anything. Thanks
> everyone for comments!
> 
> Spec URL: http://mpreisle.fedorapeople.org/pkgs/sumwars/sumwars.spec
> SRPM URL:
> http://mpreisle.fedorapeople.org/pkgs/sumwars/sumwars-0.5.6-2.fc16.src.rpm

(...)

> Copyright:
> * /tools/{meshtest,graphicengine}/Example* - this sample code is public domain,
> I have asked if it's even used in sumwars, could be just leftover
> * ./share/resources/gui/imagesets/TaharezLook.tga is a derivate of CEGUI stock
> datafile, it's CC-BY-SA only in sumwars
> * ./src/core/nlfg.h - I listed MIT in Licenses
> * I am not sure what to do about the Find*.cmake modules, they are used all
> over the place, does everyone list BSD just because of this?

I inquired on #fedora-devel and the word there was that since it's not linked
into the final binaries it is not required to be listed in the spec file.

Also, as per:
https://fedoraproject.org/wiki/Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F
...you might not be required to list 'MIT' at all, since the effective license
would be GPLv3+ there. So in fact my copyright comments seems to have a bit
unnecessary (I'm used to detailing the whole source tarball Debian-style :)

I also asked about subpackage licensing and it might be reasonable to only
state 'GPLv3+' for the main package and add a License: tag with 'CC-BY-SA' to
the -data %package section instead. Provided the license separation is as clear
as this, of course.


Overall great stuff! I don't really see anything that's awry at the moment,
IANAReviewer though, so Brendan has the final word there ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.