[Bug 802862] Review Request: drupal6-votingapi - Voting API module for Drupal6

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802862

--- Comment #3 from Rex Dieter <rdieter at math.unl.edu> 2012-03-14 13:14:35 EDT ---
$ rpmlint *.rpm noarch/*.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Sources: ok
$ md5sum *.gz
d448a23d95204b05a927067d0aa4a704  votingapi-6.x-2.3.tar.gz

Naming: ok

macros: ok

scriptlets: n/a

Licenses: NOT ok
seems the tarball includes a copy of LICENSE.txt which is standard GPLv2, and I
can't find mention of any "or later" clause to justify GPLv2+


SHOULD  consider using a simpler approach for handling
Source1: %{name}-fedora-README.txt

and drop the relevant existing %build and %files %exclude snippets, and just
use:
%files
%doc %{SOURCE1}



The rest of it is an *very* simple noarch package, though there seems to be
some unused drupal macro boilerplate, which you could trim too.


Otherwise, remaining issue is licensing per my comment above.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.