[Bug 803317] Review Request: trac-themeengine-plugin - Simple API and GUI for packaging and configuring Trac themes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=803317

Kevin Fenzi <kevin at scrye.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Kevin Fenzi <kevin at scrye.com> 2012-03-14 16:37:54 EDT ---

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (BSD)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
see below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. Might be good to ping upstream to include a copy of their license. Right now
it's just the 
setup.py statement. 

2. rpmlint says: 

trac-themeengine-plugin.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/themeengine/htdocs/jquery.rule-min.js
trac-themeengine-plugin.noarch: E: wrong-script-end-of-line-encoding
/usr/lib/python2.7/site-packages/themeengine/htdocs/jquery.rule-min.js
trac-themeengine-plugin.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/themeengine/htdocs/jquery.rule.js
trac-themeengine-plugin.noarch: E: wrong-script-end-of-line-encoding
/usr/lib/python2.7/site-packages/themeengine/htdocs/jquery.rule.js
trac-themeengine-plugin.src: W: invalid-url Source0:
trac-themeengine-plugin-2.0.1.svn11382.tar.gz
2 packages and 0 specfiles checked; 4 errors, 1 warnings.

All those could be ignored. 

I see no blockers here, so this package is APPROVED. 

Happy to co-maintain.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.