[Bug 728837] Review Request: xml2dict - Use attributes of dictionary to access xml elements.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728837

--- Comment #24 from Parag AN(पराग) <panemade at gmail.com> 2012-03-14 23:42:20 EDT ---
Review:
+ rpmlint on rpms gave
xml2dict.noarch: W: incoherent-version-in-changelog 0-0.3 ['0-0.3.2008.6',
'0-0.3.2008.6']
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ source verified with upstream as
e976006f120d7dd79a7c1a2a310d2e2fbe237d54  xml2dict-2008.6-tar.gz
e976006f120d7dd79a7c1a2a310d2e2fbe237d54  ../SOURCES/xml2dict-2008.6-tar.gz

Suggestions:
1) No need in Fedora now to write
%defattr(-,root,root,-)

2) you should ask upstream to add license headers in .py files or a separate
license file in tarball.

3) but your installation looks strange. What is need to create empty directory
install -d $RPM_BUILD_ROOT%{python_sitelib}/xml2dict

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.