[Bug 803601] Review Request: python-http-parser - HTTP request/response parser for Python

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 15 13:13:42 UTC 2012

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


--- Comment #3 from Bohuslav "Slavek" Kabrda <bkabrda at redhat.com> 2012-03-15 09:13:41 EDT ---
> You should correct the error on non standard exec. perm.

Ah, this is actually a matter of filtering the provide [1] of the .so file.

If you're not
> supporting EL5, you should remove rm -rf %{buildroot} from build section.

Yep, forgot about that. Done.

> You should use something like the following at files-section:
> %{python_sitelib}/http_parser
> %{python_sitearch}/http_parser
> %{python_sitearch}/http_parser-%{version}-py?.?.egg-info

Actually, the problem here was, that the files in "data_files" in setup.py were
placed under sitelib, not under sitearch. Therefore, on 32 bit architecture,
where these two are the same, the files were listed twice. The data files
should usually be placed alongside the others, but the upstream does a lot of
tinkering with the setup, so I just specified the location explicitly. And
everything should be ok now.

Here is the updated stuff:

SPEC: http://bkabrda.fedorapeople.org/pkgs/http-parser/python-http-parser.spec
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3897103

[1] https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list