[Bug 803423] Review Request: perl-Net-IP-Minimal - Minimal functions from Net::IP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=803423

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Petr Pisar <ppisar at redhat.com> 2012-03-15 10:06:41 EDT ---
Source file is original. Ok.
Summary verified from lib/Net/IP/Minimal.pm. Ok.
License verified from lib/Net/IP/Minimal.pm and LICENSE. Ok.
URL and Source are alive. Ok.
Description verified from lib/Net/IP/Minimal.pm. Ok.
No XS or native code. noarch BuilArch is Ok.
Build-time dependencies are Ok.
All tests pass. Ok.

$ rpmlint perl-Net-IP-Minimal.spec
../SRPMS/perl-Net-IP-Minimal-0.02-1.fc18.src.rpm
../RPMS/noarch/perl-Net-IP-Minimal-0.02-1.fc18.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Net-IP-Minimal-0.02-1.fc18.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Mar 15 15:00
/usr/share/doc/perl-Net-IP-Minimal-0.02
-rw-r--r--    1 root    root                      111 Nov 17 16:37
/usr/share/doc/perl-Net-IP-Minimal-0.02/Changes
-rw-r--r--    1 root    root                    18392 Nov 17 16:37
/usr/share/doc/perl-Net-IP-Minimal-0.02/LICENSE
-rw-r--r--    1 root    root                     1720 Nov 17 16:37
/usr/share/doc/perl-Net-IP-Minimal-0.02/README
-rw-r--r--    1 root    root                     2555 Mar 15 15:00
/usr/share/man/man3/Net::IP::Minimal.3pm.gz
drwxr-xr-x    2 root    root                        0 Mar 15 15:00
/usr/share/perl5/vendor_perl/Net
drwxr-xr-x    2 root    root                        0 Mar 15 15:00
/usr/share/perl5/vendor_perl/Net/IP
-rw-r--r--    1 root    root                     3019 Nov 17 16:37
/usr/share/perl5/vendor_perl/Net/IP/Minimal.pm
File layout and permissions are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Net-IP-Minimal-0.02-1.fc18.noarch.rpm |sort |uniq -c
      1 perl(Exporter)  
      1 perl(:MODULE_COMPAT_5.14.2)  
      1 perl(strict)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides  -p
../RPMS/noarch/perl-Net-IP-Minimal-0.02-1.fc18.noarch.rpm |sort |uniq -c
      1 perl(Net::IP::Minimal) = 0.02
      1 perl-Net-IP-Minimal = 0.02-1.fc18
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Net-IP-Minimal-0.02-1.fc18.noarch.rpm
|sort 
Binary dependencies resolvable. Ok.

Package builds in F18
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3897386). ???

Package is in line with Fedora and Perl packaging guidelines.

Resolution: Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.