[Bug 799089] Review Request: dyninst - An API for Run-time Code Generation
bugzilla at redhat.com
bugzilla at redhat.com
Thu Mar 15 21:30:38 UTC 2012
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799089
William Cohen <wcohen at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|needinfo?(wcohen at redhat.com |
|) |
--- Comment #4 from William Cohen <wcohen at redhat.com> 2012-03-15 17:30:36 EDT ---
MUST: packaging guidelines:
- bundled librares, as below
- make DESTDIR=%{buildroot} should work
( DESTDIR=... isn't currently honored in the make)
- %configure should be used
(agreed, tried to use %configure, but because of the intermixed build/
install. the build would attempt to install in /usr/lib and /usr/include
because it ignored the staged installs, if is DESTDIR honored, might be
able to use %configure)
MUST: not bundle system libraries
- boost is bundled, and is even installed into dyninst-devel.
(it looks like one can just add a BuildReqs: boost-deve and nuke the
boost
subdirectory)
ReviewGuidelines SHOULD items failed:
/usr/bin/parseThat should have a man page
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list