[Bug 801092] Review Request: sumwars - a hack and slash role playing game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=801092

--- Comment #12 from Brendan Jones <brendan.jones.it at gmail.com> 2012-03-16 02:04:14 EDT ---
Hi Martin,

sorry took a while to get back to you on this. Just of few small things.

Remove the text "Summoning Wars" from your summary. Open source here is a given
here as well.

Try to keep your spec file under 80 chars where possible. I recommend splitting
up the BuildRequires on to separate lines, but thats up to you

Use %{name} macro consistently (lines 11, 12 etc)

In the %prep section completely remove the enet/tinyXml/ogre source to be sure
subsequent versions don't build against it,

rm -rf src/enet
rm -rf src/tinyxml 
rm tools/*

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.