[Bug 804004] Review Request: python-socketpool - A simple Python socket pool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804004

--- Comment #3 from Bohuslav "Slavek" Kabrda <bkabrda at redhat.com> 2012-03-16 06:57:12 EDT ---
> Issues:
> _ I'd remove bundled egg-info during prep,
> 
>   rm -rf socketpool.egg-info
> 

True, done.

> - maybe you should use a global macro for socketpool, something like
>   %global pkgname socketpool
> 

Yes, I was thinking about that... done now.

> - you must include LICENSE

Actually, LICENSE is included. It gets into %{_docdir}/socketpool with this
line:
%{__python} setup.py install -O1 --skip-build --root %{buildroot}
--install-data %{_docdir}
You can check that in the resulting RPM.


SPEC: http://bkabrda.fedorapeople.org/pkgs/socketpool/python-socketpool.spec
SRPM:
http://bkabrda.fedorapeople.org/pkgs/socketpool/python-socketpool-0.3.0-2.fc17.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3900454

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.