[Bug 801092] Review Request: sumwars - a hack and slash role playing game
bugzilla at redhat.com
bugzilla at redhat.com
Sat Mar 17 07:05:29 UTC 2012
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=801092
Brendan Jones <brendan.jones.it at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #15 from Brendan Jones <brendan.jones.it at gmail.com> 2012-03-17 03:05:23 EDT ---
Only action items here are to remove the rm -rf $RPM_BUILDROOT unless you plan
to build for EPEL5
This package is APPROVED.
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
==== C/C++ ====
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains a properly installed %{name}.desktop using desktop-
file-install file if it is a GUI application.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[?]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
This is OK
rpmlint sumwars-0.5.6-4.fc18.src.rpm
sumwars.src: W: spelling-error %description -l en_US multiplayer -> multiplier,
multiplexer
sumwars.src:73: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 73)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint sumwars-0.5.6-4.fc18.i686.rpm
sumwars.i686: W: spelling-error %description -l en_US multiplayer ->
multiplier, multiplexer
sumwars.i686: W: no-manual-page-for-binary sumwars
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint sumwars-debuginfo-0.5.6-4.fc18.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint sumwars-data-0.5.6-4.fc18.noarch.rpm
sumwars-data.noarch: W: no-documentation
sumwars-data.noarch: W: dangling-symlink
/usr/share/sumwars/resources/gui/fonts/DejaVuSerif.ttf
/usr/share/fonts/dejavu/DejaVuSerif.ttf
sumwars-data.noarch: W: dangling-symlink
/usr/share/sumwars/resources/gui/fonts/DejaVuSans.ttf
/usr/share/fonts/dejavu/DejaVuSans.ttf
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/bsjones/rpmbuild/SRPMS/sumwars-0.5.6-src.tar.bz2 :
MD5SUM this package : 89f53fe1023072785e039bdef312a04b
MD5SUM upstream package : 950694019f66122a7deff11680cf1feb
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[-]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD Scriptlets must be sane, if used.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec use %global instead of %define.
Issues:
[!]: MUST Package contains a properly installed %{name}.desktop using desktop-
file-install file if it is a GUI application.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[!]: MUST Rpmlint output is silent.
rpmlint sumwars-0.5.6-4.fc18.src.rpm
sumwars.src: W: spelling-error %description -l en_US multiplayer -> multiplier,
multiplexer
sumwars.src:73: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 73)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint sumwars-0.5.6-4.fc18.i686.rpm
sumwars.i686: W: spelling-error %description -l en_US multiplayer ->
multiplier, multiplexer
sumwars.i686: W: no-manual-page-for-binary sumwars
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint sumwars-debuginfo-0.5.6-4.fc18.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint sumwars-data-0.5.6-4.fc18.noarch.rpm
sumwars-data.noarch: W: no-documentation
sumwars-data.noarch: W: dangling-symlink
/usr/share/sumwars/resources/gui/fonts/DejaVuSerif.ttf
/usr/share/fonts/dejavu/DejaVuSerif.ttf
sumwars-data.noarch: W: dangling-symlink
/usr/share/sumwars/resources/gui/fonts/DejaVuSans.ttf
/usr/share/fonts/dejavu/DejaVuSans.ttf
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/bsjones/rpmbuild/SRPMS/sumwars-0.5.6-src.tar.bz2 :
MD5SUM this package : 89f53fe1023072785e039bdef312a04b
MD5SUM upstream package : 950694019f66122a7deff11680cf1feb
See: http://fedoraproject.org/wiki/Packaging/SourceURL
Generated by fedora-review 0.1.3
External plugins:
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list