[Bug 798071] Review Request: fedora-arm-installer - Writes binary image files to any specified block device

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798071

--- Comment #3 from Michael Scherer <misc at zarb.org> 2012-03-18 07:06:45 EDT ---
Indeed, you cannot edit the post. Think of it like a mailing list more than
like a forum :)

1) I think, but I am not sure, that it would be better to use exec in the last
part of the helper script :
export GNOME_DESKTOP_SESSION_ID=needed
%{_sbindir}/%{name}

this way, you have only one process in the process table, and not 2, this is
cleaner.

2) if you use consolehelper, I think you should have a requires on usermode.
Even if this is installed by default on graphical desktop ( being required by
firstboot ), it can be removed.


3) the license should be present in a %doc :
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

4) the requires is on python, I think you should tell if this is version 2 or
3.


I need to go, so I will add some remarks later ( once I have done enough
research too )

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.