[Bug 542580] Review Request: statusnet - Open Source microblogging platform

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542580

Michael Scherer <misc at zarb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misc at zarb.org

--- Comment #16 from Michael Scherer <misc at zarb.org> 2012-03-18 18:36:36 EDT ---
A few comments :
- you should drop %defattr and %clean, unless you plan to backport to EPEL 5

- %check seems to be empty, so maybe you can drop this

- since laconica is not in fedora repository ( and long forgotten ), maybe this
is not needed to provide it

- why is there user creation, if it doesn't serve to anything ( ie, that's a
php software, and I didn't see any cron job or reason to think anything would
use it )

- Requiring mysql-server is IMHO wrong, since the sql server can be on another
server. On the other hand, I didn't found any guideline against that.

- BuildRoot can also be removed

- rm -rf %buildroot can be removed at the beggining of %install

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.