[Bug 753676] Review Request: gnome-shell-extention-netspeed -an internet speed indicator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753676

--- Comment #19 from Parag AN(पराग) <panemade at gmail.com> 2012-03-19 06:20:05 EDT ---
Review:

+ koji scratch build for f17 ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=3908555

+ rpmlint on rpms gave
gnome-shell-extension-netspeed.noarch: W: no-documentation
gnome-shell-extension-netspeed.src: W: invalid-url Source0:
gnome-shell-extension-netspeed-3.2.9.tar.gz
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ package follows guidelines.

Suggestions:
1)you should provide steps in spec above source0: tag on how to create a
tarball.

2) Any reason for not using disttag? See
http://fedoraproject.org/wiki/Packaging:DistTag how to add dist-tag.

3)  Package is installed successfully but unable to get extension working. Look
like you need to modify metadata.json to include new gnome-shell versions. I
tested on f17 and this is not working. After adding "3.3.90" as gnome-shell
version it start working.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.