[Bug 753677] Review Request: gnome-shell-extension-no11y - remove acceblity icon from status area
bugzilla at redhat.com
bugzilla at redhat.com
Mon Mar 19 10:16:57 UTC 2012
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753677
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|177841(FE-NEEDSPONSOR) |
--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2012-03-19 06:16:56 EDT ---
Review:
+ koji scratch build for f17 ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=3908553
+ rpmlint on rpms gave
gnome-shell-extension-noa11y.noarch: W: no-documentation
gnome-shell-extension-noa11y.src: W: invalid-url Source0:
gnome-shell-extension-noa11y-3.2.0.tar.gz
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
+ upstream source URL is verified as (sha1sum)
7e59257df57d226a9b8f950a33a48a5f8db57152
../SOURCES/gnome-shell-extension-noa11y-3.2.0.tar.gz
7e59257df57d226a9b8f950a33a48a5f8db57152
gnome-shell-extension-noa11y-3.2.0.tar.gz
+ package follows guidelines.
Suggestions:
1)Source tag should
Source0:
http://www.cs.sfu.ca/~aha49/personal/fedora/%{name}-%{version}.tar.gz
2) URL tag should contain a link where this project is hosted. If its nowhere
hosted then remove the URL tag.
3) Any reason for not using disttag? See
http://fedoraproject.org/wiki/Packaging:DistTag how to add dist-tag.
4) Package is installed successfully but unable to get extension working. Look
like you need to modify metadata.json to include new gnome-shell versions. I
tested on f17 and this is not working. After adding "3.3.90" as gnome-shell
version it start working.
Please fix the suggestions before you add this package in dist-git.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list