[Bug 773011] Review Request: api-sanity-checker - An automatic generator of basic unit tests for a shared C/C++ library.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=773011

--- Comment #9 from Richard Shaw <hobbes1069 at gmail.com> 2012-03-19 10:33:03 EDT ---
(In reply to comment #5)
> Build fails on help2man:
> 
> + help2man -h --info -o
> /home/limb/rpmbuild/BUILDROOT/api-sanity-checker-1.12.9-2.fc16.x86_64/usr/share/man/man1/api-sanity-checker.1
> -N api-sanity-checker
> help2man: can't get `--info' info from api-sanity-checker
> Try `--no-discard-stderr' if option outputs to stderr

Doh! I've already got it installed on my system so of course it finds the
installed script, not the one in the buildroot. I haven't bothered to build
this in mock since it's just a script but that would have caught this.


> Change help2man line to:
> 
> help2man -o %{buildroot}%{_mandir}/man1/api-sanity-checker.1 -N 'perl
> api-sanity-checker.pl'

Hmm... Not that it really matters but this would run the script in the BUILD
(source) directory, not the one in the BUILDROOT. 


> License tag needs updating to GPLv2.

Yeah, the text at the top of the LICENCE.txt file is confusing. Fixed.

Spec URL:
http://hobbes1069.fedorapeople.org/api-sanity-checker/api-sanity-checker.spec
SRPM URL:
http://hobbes1069.fedorapeople.org/api-sanity-checker/api-sanity-checker-1.12.9-3.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.