[Bug 798998] Review Request: libcdr - a library for import of Corel Draw drawings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798998

Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mschwendt at gmail.com
               Flag|                            |fedora-review+

--- Comment #6 from Michael Schwendt <mschwendt at gmail.com> 2012-03-20 07:19:41 EDT ---
* Release 0.0.5 fixes the licensing issues and explicitly acknowledges the
tri-license in the README even.


* New file src/lib/CDRColorProfiles.h uses the compatible zlib/libpng "no
acknowledgement" license.


* Please add  V=1  to the Make invocation for more verbose build output.


* The pkgconfig file is worse in release 0.0.5. It explicitly adds a dependency
on libraries that are linked with libcdr already. In 0.0.5 it has added a
dependency on lcms2 and zlib in "Requires" and/or "Libs". Whereas libwpd* and
libwpg headers are included from within libcdr headers at least (and the
pkgconfig dependency can help with getting their custom include path right),
relinking with lcms2 and zlib would not be necessary.


* APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.