[Bug 605674] Review Request: perl-IO-InSitu - Avoid clobbering files opened for both input and output

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605674

Paul Howarth <paul at city-fan.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|rawhide                     |1.4
          Component|Package Review              |unknown
                 CC|                            |asalkeld at redhat.com,
                   |                            |jfriesse at redhat.com,
                   |                            |sdake at redhat.com
            Product|Fedora                      |Corosync Cluster Engine
               Flag|fedora-review?              |
         OS/Version|Linux                       |Unspecified

--- Comment #8 from Paul Howarth <paul at city-fan.org> 2012-03-20 11:43:22 EDT ---
OK, time to take another look at this.

With rpm 4.9, the automatic dependency finder detects the "use base" construct
and so you no longer need the explicit perl(IO::File) dependency for current
Fedora versions. For all EPEL releases, which all have older versions of rpm,
the IO::File module is bundled with the main perl package so it's not really
needed there either. So I'd now suggest getting rid of that requirement.

Looking at build requirements, the module uses the following dual-lived modules
that are not explicitly build-required:

* perl(base)
* perl(Carp)
* perl(File::Temp)
* perl(IO::File)

I'd add build-requires for those given that they may be dual-lived in Fedora
either now or in the future.

It's not actually necessary to remove empty directories from the buildroot as
rpm-build will not include them in the package unless they're included in the
%files list, and it won't complain about them either.

rpm 4.9 now has a native method for filtering unwanted requires and provides.
The method used in this spec file will work for current Fedora releases and
EPEL 6 but not EPEL 5. If you want filters that work everywhere, you'll
currently need to use two sets of filters - for example as I've done in the
perl-SUPER package:

http://pkgs.fedoraproject.org/gitweb/?p=perl-SUPER.git;a=blob;f=perl-SUPER.spec

That's using rpm 4.9's native filtering and the old %__perl_provides macro as a
fallback for older rpm versions.

Using macros for commands (e.g. %{__perl}, %{__id_u} -n) is now discouraged:
http://fedoraproject.org/wiki/Packaging:Guidelines#Macros

I'd just use "perl" and "id -nu" in these cases now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.