[Bug 605674] Review Request: perl-IO-InSitu - Avoid clobbering files opened for both input and output

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605674

Paul Howarth <paul at city-fan.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #10 from Paul Howarth <paul at city-fan.org> 2012-03-21 10:22:37 EDT ---
OK, last few nits:

%defattr is redundant in all currently supported releases, including EPEL-5.

You missed a %{__perl} in the :MODULE_COMPAT dependency.

Given that there's only one "provide" needing to be filtered, the "traditional"
filter is over-escaped and you could simplify the grep to:
grep -Fvx 'perl(IO::File::SE)'

None of those are blockers though.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.