[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=786213

--- Comment #4 from Kevin Fenzi <kevin at scrye.com> 2012-03-21 12:22:35 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (ASL 2.0)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
fe527f0b0a2391394e4c7139b8718dae  agilo_source.tar.gz
fe527f0b0a2391394e4c7139b8718dae  agilo_source.tar.gz.orig

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
See below - Package has a correct %clean section. 
See below - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
See below - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
See below - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. You might ask upstream to include a copy of the license. 
Not a blocker though. 

2. You don't need a builtroot or clean section for Fedora anymore, but 
you do for EPEL6, so you might add those back for that. 

3. You need a
rm -rf %{buildroot}
at the top of the install section. 

4. rpmlint says: 

Can be ignored, but man pages would be nice: 

trac-agilo-plugin.noarch: W: no-manual-page-for-binary agilo_sqlite2pg
trac-agilo-plugin.noarch: W: no-manual-page-for-binary create_agilo_project
trac-agilo-plugin.noarch: W: no-manual-page-for-binary agilo_svn_hook_commit

You should change all the commented macros to %%

trac-agilo-plugin.src:30: W: macro-in-comment %check
trac-agilo-plugin.src:31: W: macro-in-comment %{python_sitelib}
trac-agilo-plugin.src:32: W: macro-in-comment %{python_sitelib}
trac-agilo-plugin.src:33: W: macro-in-comment %{_defaultdocdir}
trac-agilo-plugin.src:33: W: macro-in-comment %{VERSION}
trac-agilo-plugin.src:34: W: macro-in-comment %{buildroot}
trac-agilo-plugin.src:34: W: macro-in-comment %{python_sitelib}
trac-agilo-plugin.src:34: W: macro-in-comment %{__python}

Can be ignored: 

trac-agilo-plugin.src: W: invalid-url Source0: agilo_source.tar.gz

5. Is there a specific version of trac thats required?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.