[Bug 803089] Review Request: whenjobs - Replacement for cron with dependencies

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=803089

--- Comment #10 from Richard W.M. Jones <rjones at redhat.com> 2012-03-22 04:42:11 EDT ---
(In reply to comment #9)
> So :
> 
> - The guideline say that you should use %global instead of %define :
> https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

Grrrr!
http://git.annexia.org/?p=whenjobs.git;a=commitdiff;h=ea28f8eebc4d8434e7e66d62b769d747656d27ae

> - there is no need nowadays to clean the buildroot before install 
> https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

http://git.annexia.org/?p=whenjobs.git;a=commitdiff;h=a84570d0991652a864d90e8e3fee685cc05982c7

> - the line
> %define opt %(test -x %{_bindir}/ocamlopt && echo 1 || echo 0) 
> is still not used. If you have added directly support in the makefile, then
> this line can be removed, no ?

http://git.annexia.org/?p=whenjobs.git;a=commitdiff;h=2c27f26c486961d1b7799d4f4274aa31d04df845

> - why are debug disabled ? While I am sure that you have good reasons, it
> should be mentioned in a comment ( and that's maybe the reason why you have to
> strip by hand the software, as you mention later in the spec )

The reason is that the OCaml compiler doesn't add DWARF
information to its output, so you end up with debuginfo
files that work but are content-free.  This is a standard
thing that is added to every OCaml spec file, eg picking
one at random:
http://pkgs.fedoraproject.org/gitweb/?p=ocaml-pcre.git;a=blob;f=ocaml-pcre.spec;hb=HEAD

I've no idea why stripping didn't happen.  It *does*
happen normally, even with debug disabled, so it could
be a bug in my local RPM, but in any case rpmlint warned
about it, and stripping twice won't be a problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.