[Bug 682553] Review Request: python26-pycurl - A Python interface to libcurl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682553

Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mattias.ellert at fysast.uu.se
               Flag|                            |fedora-review+

--- Comment #6 from Mattias Ellert <mattias.ellert at fysast.uu.se> 2012-03-24 19:16:17 EDT ---
Fedora Review python26-pycurl

rpmlint output:

rpmlint 2248713324973631270127050/result/python26-pycurl/*.rpm
python26-pycurl.src: W: spelling-error Summary(en_US) libcurl -> lib curl,
lib-curl, curlicue
python26-pycurl.src: W: spelling-error %description -l en_US libcurl -> lib
curl, lib-curl, curlicue
python26-pycurl.src: W: spelling-error %description -l en_US urllib -> gullible
python26-pycurl.src: W: invalid-url Source0:
http://pycurl.sourceforge.net/download/pycurl-7.15.5.1.tar.gz HTTP Error 404:
Not Found
python26-pycurl.x86_64: W: spelling-error Summary(en_US) libcurl -> lib curl,
lib-curl, curlicue
python26-pycurl.x86_64: W: spelling-error %description -l en_US libcurl -> lib
curl, lib-curl, curlicue
python26-pycurl.x86_64: W: spelling-error %description -l en_US urllib ->
gullible
python26-pycurl.x86_64: E: incorrect-fsf-address
/usr/share/doc/python26-pycurl-7.15.5.1/COPYING
3 packages and 0 specfiles checked; 1 errors, 7 warnings.

The source tarball has moved:
http://pycurl.sourceforge.net/download/00-OLD-VERSIONS/pycurl-7.15.5.1.tar.gz


+ Package name is appropriate for a python 2.6 package
+ Specfile is named after the package
+ Package is licensed under a Fedoara approved license
+ Package license matches the license statements in the sources
+ License file (COPYING) is included in the package
+ Specfile is written in legible English
+ Source in the package matches the upstream source:

md5sum pycurl-7.15.5.1.tar.gz srpm/pycurl-7.15.5.1.tar.gz 
464cfbeba150d99d92a407c7c8b751de  pycurl-7.15.5.1.tar.gz
464cfbeba150d99d92a407c7c8b751de  srpm/pycurl-7.15.5.1.tar.gz

+ Package builds in mock
+ Build requirements are sane
+ No locales
+ No shared libraries in default library path
+ No bundled libraries
+ Package owns directories it created
+ No duplicates in %files
+ File permissions are sane
+ The specfile uses macros consistently
+ Package contains code
+ %doc not runtime essential
+ No static libraries
+ No development files
+ No subpackages
+ No libtool archives
+ Package does not own other's directories
+ Installed filenames are UTF-8


Apart from that the source has moved to a new location on the upstream server,
the package is good. Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.