[Bug 730697] Review Request: python26-h5py - Python interface to the HDF5 library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=730697

Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mattias.ellert at fysast.uu.se
         AssignedTo|nobody at fedoraproject.org    |mattias.ellert at fysast.uu.se
               Flag|                            |fedora-review+

--- Comment #1 from Mattias Ellert <mattias.ellert at fysast.uu.se> 2012-03-25 11:12:16 EDT ---
Fedora review python26-h5py

rpmlint 86961332675217766851026/result/python26-h5py/*.rpm
python26-h5py.src: W: invalid-url Source0:
http://h5py.googlecode.com/files/h5py-1.3.1.tar.gz HTTP Error 404: Not Found
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

The warnong is bogus, the source tarfile exists of the given URL.

+ The package name is appropriate for a python 2.6 package in EPEL
+ The specfile is named after the package
+ The package is licensed under a Fedora approved license (BSD)
+ The package license matches the license staements in the sources
+ The license file (License.txt) is included in the package
+ The specfile is written in legible English
+ Soutces matches upstream:

$ md5sum srpm/h5py-1.3.1.tar.gz h5py-1.3.1.tar.gz 
cfef84992d33910a06371dc35becb71b  srpm/h5py-1.3.1.tar.gz
cfef84992d33910a06371dc35becb71b  h5py-1.3.1.tar.gz

+ Package builds in mock
+ Build requires are sensible
+ No locales
+ No shared libraries in default library path
+ The bundled lzf code is not used (patch applied)
+ Package owns the directories it creates
+ No duplication in %files
+ File permissions are sane
+ Specfile uses macros consistently
+ Contains code
+ %doc not runtime essential
+ No static libraries
+ No development files
+ No subpackages
+ No libtool archives
+ Package does not own directories owned by other packages
+ Filenames ar valid UTF8

PACKAGE APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.