[Bug 804666] Review Request: libpfm - Library to encode performance events for use by perf tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804666

--- Comment #2 from Michael Schwendt <mschwendt at gmail.com> 2012-03-25 16:18:32 EDT ---
* https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


*
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries


* https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag


* https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean


> %{!?with_python: %global with_python 1}

You may want to look into using "%bcond_without python" instead.


> %defattr(644,root,root,755)
> %doc README

https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions


> %attr(755,root,root) %{_libdir}/lib*.so*

Ownership is root:root by default. If the mode is not 0755 for the installed
lib, I highly recommend fixing it upstream and temporarily during %install.
Usage of the eye-catching %attr should be limited to non-ordinary file
permissions as not to overuse it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.