[Bug 711899] Review Request: opendnssec - DNSSEC key and zone management software
bugzilla at redhat.com
bugzilla at redhat.com
Mon Mar 26 13:40:10 UTC 2012
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711899
--- Comment #16 from Jon Ciesla <limburgher at gmail.com> 2012-03-26 09:40:07 EDT ---
rpmlint:
opendnssec.spec:7: W: macro-in-comment %{name}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
opendnssec.spec:7: W: macro-in-comment %{version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
Fix before import.
Lots of non-standard uid/gid errors, expected with custom user.
You're missing an -m on line 49 for install, which results in a spurious 0755
dir in the buildroot, and no unitdir, though unitdir is in the final RPM.
One other issue, the sources refer to a LICENSE file that's not there.
So it's just the install, the commented macros, and the LICENSE file. Mock
build is good. :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list