[Bug 611372] Review Request: perl-Net-Twitter - Perl interface to Twitter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611372

--- Comment #16 from Petr Šabata <psabata at redhat.com> 2012-03-27 09:30:46 EDT ---
Looking at the changes...

You've added the required build time dependencies, including the optional ones.
OK.

You've removed %defattr, the BuildRoot tag, buildroot removal in %install but
you've kept the %clean section. You could just drop it entirely.
Sort of OK.

About the runtime dependencies -- sadly, rpmbuild doesn't detect everything. It
usually fails with 'use's and 'require's in indented blocks, for example.
I see you've just removed them all. I think you're missing some deps now but
I'll have to check that again...

I usually respect the versions in Makefile/META since those are the versions
the original author developed and tested the module with.  However, as I said
before, it's up to you :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.