[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802050

--- Comment #2 from Gregor Tätzner <gregor at freenet.de> 2012-03-27 13:56:06 EDT ---
just a quick shot:

- your package doesnt build in mock
->add desktop-file-utils and libtool as BuildRequires

- place your sed magic in the %install section :)

- please explain the optional patch. Why did you include it? Why isn't it in
upstream?

(In reply to comment #0)
> >love.x86_64: W: no-manual-page-for-binary love
> 
> This isn't critical, so ignored it. I can write a man page and send it upstream
> if needed.
yeah non critical, but it would be really *cool* if you can do it :)

> >love.src: W: invalid-url Source1: love-extra.tar.xz
> 
> This source does not have a download link because I created it; a link above
> the source provides the source for the files I included (from Ubuntu's Debian
> files). I can provide a script
> to generate this if necessary.
is there some reason why you didn't send this to upstream?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.