[Bug 807662] Review Request: gnome-font-viewer - Utility for previewing fonts for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=807662

--- Comment #3 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2012-03-28 10:24:18 EDT ---
The package looks very good. Just two suggestions:
* you should enable the --disable-silent-rules option in %configure: even if
the build process used in GNOME projects is usually safe, I'd be more confident
if the compilation lines are explicitely displayed in the build logs
* To make future updates of this package easier, you could define a
%major_version macro, set to "3.4" here,, that you could use in the Source0
tag, and even in Version. I use such a trick in my GNOME packages. But it's not
mandatory ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.