[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799651

--- Comment #12 from Rex Dieter <rdieter at math.unl.edu> 2012-03-28 10:23:45 EDT ---
Re: 4
then please use
BuildRequires: kdelibs4-devel >= 4.4
though I'd still argue the 4.4 is not needed, all versions of fedora shipping
now satisfy that.

Re: 5
I'm arguing just remove that snippet about links from the .spec altogether. 
It's not needed, and just clutters and complicates the .spec

Re: 6
I see no explanation or documented reasons for  
 --add-category Network
 --add-category FileTransfer
 --add-category FileManager
did I overlook something?

A simple comment in the .spec near the desktop-file-install call would be
sufficient.
did I overlook something?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.