[Bug 807662] Review Request: gnome-font-viewer - Utility for previewing fonts for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=807662

--- Comment #6 from Kalev Lember <kalevlember at gmail.com> 2012-03-28 12:22:41 EDT ---
> %define         major   3
> %define         minor   4
> %define         micro   0
> Version:        %{major}.%{minor}.%{micro}

I'd rather not define Version like this, mostly because Fedora packagers (and
automatic tools) expect to be able change the Version tag directly when needed.
I'm not trying to say it's in any way bad to split it up; it's just that Fedora
packagers aren't used to doing that. For instance, hughsie's mclazy script will
get into trouble editing this.
https://gitorious.org/mclazy/mclazy/trees/master

If you want to automate the download URL construction, I'd rather create a
macro that takes apart the version string in the Version tag:
# first two digits of version
%define release_version %(echo %{version} | awk -F. '{print $1"."$2}')
(name it to your liking)

... and then uses it in Source0:
Source0:
http://ftp.gnome.org/pub/GNOME/sources/gnome-font-viewer/%{release_version}/%{name}-%{version}.tar.xz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.