[Bug 807662] Review Request: gnome-font-viewer - Utility for previewing fonts for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=807662

--- Comment #9 from Kalev Lember <kalevlember at gmail.com> 2012-03-28 13:08:22 EDT ---
Just mentioning something I noticed, not saying anything should be changed:

You've placed the release_version macro definition right after the Version tag,
presumably to make rpmlint happy. However, this macro can also work when placed
at the top of the spec file, but then it needs to:
a) be a %define
b) use lazy expansion if you want to use a %global:
%global release_version %%(echo %{version} | awk -F. '{print $1"."$2}')

Note the two %% in (b). One of the differences between %define and %global is
that the former does lazy expansion by default, whereas %global does not.

(Again, I have no preference where the macro definition should be, just
mentioning it in case you wanted to place it at the top of the file but
couldn't because of rpmlint.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.