[Bug 807472] Review Request: libstoragemgmt - Library for storage array management

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=807472

--- Comment #3 from Michael Schwendt <mschwendt at gmail.com> 2012-03-29 14:58:22 EDT ---
> but the /* appears to be required.

Correct. You also need it behind %{python_sitelib} for exactly the reason
you've given. Example with expanded macros:

  /usr/bin/*

would include any files in /usr/bin, whereas

  /usr/bin
or the more explicit
  /usr/bin/

would include the directory /usr/bin and anything in it. So,

  %{python_sitelib}

would also include Python's site-packages directory, which does not belong into
your package.


> Summary:        A library for storage array management

The majority of package summaries omit leading articles, which makes them much
more pretty when displayed in in Anaconda (and package tools).


> Requires:       %{name} = %{version}-%{release}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %post 
> /sbin/ldconfig

Just want to point out, this means that there is no automatic dependency on
/sbin/ldconfig.


> %files devel
> %defattr(-,root,root,-)
> %doc README COPYING.LIB

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.