[Bug 805037] Review Request: commons-compiler - Interfaces for an embedded Java compiler

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 29 20:14:40 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805037

--- Comment #4 from Jerry James <loganjerry at gmail.com> 2012-03-29 16:14:39 EDT ---
Here goes my first attempt at using fedora-review.

I'd like to suggest listing "http://www.janino.net/" as the URL.  It redirects
to the URL in the spec file, and is easier to read and remember.

Also, this will fix one broken javadoc link:

sed -i "s|link ClassBodyEvaluator|link IClassBodyEvaluator|" \
    org/codehaus/commons/compiler/samples/ClassBodyDemo.java

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf is only needed if supporting EPEL5
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[-]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint commons-compiler-2.6.1-1.fc18.noarch.rpm

commons-compiler.noarch: W: spelling-error %description -l en_US codehaus ->
Wodehouse
commons-compiler.noarch: W: spelling-error %description -l en_US
IExpressionEvaluator -> Professionalization
commons-compiler.noarch: W: spelling-error %description -l en_US
IScriptEvaluator -> Discriminatory
commons-compiler.noarch: W: spelling-error %description -l en_US
IClassBodyEvaluator
commons-compiler.noarch: W: spelling-error %description -l en_US
ISimpleCompiler -> Recompile
commons-compiler.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 6 warnings.


rpmlint commons-compiler-2.6.1-1.fc18.src.rpm

commons-compiler.src: W: spelling-error %description -l en_US codehaus ->
Wodehouse
commons-compiler.src: W: spelling-error %description -l en_US
IExpressionEvaluator -> Professionalization
commons-compiler.src: W: spelling-error %description -l en_US IScriptEvaluator
-> Discriminatory
commons-compiler.src: W: spelling-error %description -l en_US
IClassBodyEvaluator
commons-compiler.src: W: spelling-error %description -l en_US ISimpleCompiler
-> Recompile
1 packages and 0 specfiles checked; 0 errors, 5 warnings.


rpmlint commons-compiler-javadoc-2.6.1-1.fc18.noarch.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


[!]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/jamesjer/Projects/review/805037/commons-compiler-2.6.1-sources.jar :
  MD5SUM this package     : c01cc19cb514648d678ddf36c8d8a8a8
  MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
/home/jamesjer/Projects/review/805037/commons-compiler-2.6.1.pom :
  MD5SUM this package     : f99e0f69541e17c8f160799b056720b4
  MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e

This is because I get HTTP 403: Forbidden on the source URLs.  The md5sums
above are what you get on a 0-byte file.  Have the sources moved?  The only
source file I can find is http://dist.codehaus.org/janino/janino-2.6.1.zip,
which includes both commons-compiler and janino itself.

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[!]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[!]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[-]: SHOULD %check is present and all tests pass.
[!]: SHOULD Packages should try to preserve timestamps of original installed
     files.  Add "-p" to "cp %{SOURCE1} ./pom.xml".
[x]: SHOULD Spec use %global instead of %define.


==== Java ====
[x]: MUST If source tarball includes bundled jar/class files these need to be
     removed prior to building
[x]: MUST Packages have proper BuildRequires/Requires on jpackage-utils
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: MUST Javadoc subpackages have Requires: jpackage-utils
[x]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version}
     symlink)
[x]: SHOULD Package has BuildArch: noarch (if possible)
[x]: SHOULD Package uses upstream build method (ant/maven/etc.)


==== Maven ====
[x]: MUST Pom files have correct add_maven_depmap call
     Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: MUST Old add_to_maven_depmap macro is not being used
[x]: MUST Packages DOES NOT have Requires(post) and Requires(postun) on
     jpackage-utils for %update_maven_depmap macro
[x]: MUST If package contains pom.xml files install it (including depmaps)
     even when building with ant
[x]: MUST Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: MUST Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

Issues:
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf is only needed if supporting EPEL5
See: None
[!]: MUST Rpmlint output is silent.

rpmlint commons-compiler-2.6.1-1.fc18.noarch.rpm

commons-compiler.noarch: W: spelling-error %description -l en_US codehaus ->
Wodehouse
commons-compiler.noarch: W: spelling-error %description -l en_US
IExpressionEvaluator -> Professionalization
commons-compiler.noarch: W: spelling-error %description -l en_US
IScriptEvaluator -> Discriminatory
commons-compiler.noarch: W: spelling-error %description -l en_US
IClassBodyEvaluator
commons-compiler.noarch: W: spelling-error %description -l en_US
ISimpleCompiler -> Recompile
commons-compiler.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 6 warnings.


rpmlint commons-compiler-2.6.1-1.fc18.src.rpm

commons-compiler.src: W: spelling-error %description -l en_US codehaus ->
Wodehouse
commons-compiler.src: W: spelling-error %description -l en_US
IExpressionEvaluator -> Professionalization
commons-compiler.src: W: spelling-error %description -l en_US IScriptEvaluator
-> Discriminatory
commons-compiler.src: W: spelling-error %description -l en_US
IClassBodyEvaluator
commons-compiler.src: W: spelling-error %description -l en_US ISimpleCompiler
-> Recompile
1 packages and 0 specfiles checked; 0 errors, 5 warnings.


rpmlint commons-compiler-javadoc-2.6.1-1.fc18.noarch.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[!]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/jamesjer/Projects/review/805037/commons-compiler-2.6.1-sources.jar :
  MD5SUM this package     : c01cc19cb514648d678ddf36c8d8a8a8
  MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
/home/jamesjer/Projects/review/805037/commons-compiler-2.6.1.pom :
  MD5SUM this package     : f99e0f69541e17c8f160799b056720b4
  MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e

See: http://fedoraproject.org/wiki/Packaging/SourceURL


Generated by fedora-review 0.1.3
External plugins:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list